Skip to content

fix(contract+lock): extend ogar_codebook mirror with PRODUCT + ACCOUNTING_ACCOUNT (OGAR #111) and bump pin#597

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/contract-mirror-product-and-accounting-account-from-ogar-111
Jun 23, 2026
Merged

fix(contract+lock): extend ogar_codebook mirror with PRODUCT + ACCOUNTING_ACCOUNT (OGAR #111) and bump pin#597
AdaWorldAPI merged 1 commit into
mainfrom
claude/contract-mirror-product-and-accounting-account-from-ogar-111

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

D2 — follow-up to the sibling-merged D1

Sibling PR 81d08c42 (D1, merged earlier today) mirrored OGAR #110's auth
domain. OGAR #111 just merged on the same day, adding two more entries
to ogar_vocab::class_ids::ALL:

  • product 0x0207product.template / product.product converge here
  • accounting_account 0x0208account.account / account.account.template
    converge here

(Same convergence pattern as account.move ↔ sale.order → commercial_document.)

Without this sync, lance_graph_ogar::parity::COUNT_FUSE const-eval-panics
the moment a consumer bumps its OGAR pin to current main: mirror=43, ALL=45.
Same shape as the q2 #42 trigger that exposed D1's drift.

Background — D #596 closed in favor of this

When PR #596 (my original D, attempted to fix the OGAR #110 mirror) tried
to rebase onto main, it conflicted with the now-merged sibling D1
(81d08c42). #596 is closed; this PR (D2) is the new follow-up, scoped
to the next drift (OGAR #111) using the discipline named in
E-OGAR-AUTH-MIRROR-DRIFT.

Two coordinated fixes

  1. lance-graph-contract: extend ogar_codebook::CODEBOOK with the 2 new
    commerce-arm entries. No new ConceptDomain variant — both stay Commerce
    (0x02XX). 6 lines added.

  2. Workspace Cargo.lock: bump pinned OGAR crates (ogar-vocab,
    ogar-class-view, ogar-ontology, ogar-adapter-surrealql) from
    08a9c979ac4b4162 (current OGAR main, post-docs: add γ+φ encoding + ModelPipeline DTO + Jina eval to handover Complete next-session pipeline: 1. Temperature fix (nucleus + thinking styles) 2. γ+φ golden ratio HDR re-encoding (per-role, Gate γ=1.50) 3. StandardizedModelPipeline DTO (6 models) 4. Jina cross-model eval (truth anchor) 5. Maverick 128E streaming (800 GB → ~1.2 GB) https://claude.ai/code/session_01ChLvBfpJS8dQhHxRD4pYNp #111 merge). 4 refs.

Safe SHA swap verified — Cargo.toml deps byte-identical between the two
commits:

ogar-vocab               0
ogar-class-view          0
ogar-ontology            0
ogar-adapter-surrealql   0

Tests

  • cargo test -p lance-graph-contract: 9 doctests pass (compile-time fuse passes)
  • cargo test --lib in crates/lance-graph-ogar: 53/53 pass, including
    parity::tests::mirror_is_a_faithful_copy_of_ogar_codebook
  • cargo build -p lance-graph-ogar: clean

Discipline working as designed

This PR demonstrates the E-OGAR-AUTH-MIRROR-DRIFT epiphany (in EPIPHANIES.md
since sibling D1) holding: OGAR #111 merged this morning, the mirror catches
up this afternoon (instead of three days later when q2's lock bumps). Same
PR shape as D1; same minimal scope.

Source-of-finding

…TING_ACCOUNT (OGAR #111) and bump pin

D2 — follow-up to the merged sibling D1 (lance-graph #595, `81d08c42`)
which mirrored OGAR #110's auth domain. OGAR #111 just merged on the same
day, adding two more entries to `ogar_vocab::class_ids::ALL`:
  - `product 0x0207`  (← `product.template` / `product.product` converge)
  - `accounting_account 0x0208`  (← `account.account` /
                                    `account.account.template` converge)

Without this sync, `lance_graph_ogar::parity::COUNT_FUSE` panics again
the moment a consumer (q2's Railway docker build is the canary) bumps
its own OGAR pin to current main: mirror=43, ALL=45.

Two coordinated fixes:

1. lance-graph-contract: extend ogar_codebook::CODEBOOK with the 2 new
   commerce-arm entries. Same convergence pattern as `commercial_document`
   (which both `account.move` and `sale.order` resolve to). No new
   ConceptDomain variant — both stay in Commerce (0x02XX).

2. Workspace Cargo.lock: bump pinned OGAR crates
   (ogar-vocab / ogar-class-view / ogar-ontology / ogar-adapter-surrealql)
   from `08a9c979` → `ac4b4162` (current OGAR main, post-#111 merge).
   4 references in this lock.

Safe SHA swap verified: Cargo.toml deps for all four OGAR crates are
byte-identical between the two commits (`git diff 08a9c979..ac4b4162
-- crates/{ogar-vocab,ogar-class-view,ogar-ontology,
ogar-adapter-surrealql}/Cargo.toml` returns EMPTY).

Tests:
  - lance-graph-contract: 9 doctests pass (compile-time COUNT_FUSE passes)
  - lance-graph-ogar lib: 53/53 pass including
    parity::tests::mirror_is_a_faithful_copy_of_ogar_codebook
  - cargo build -p lance-graph-ogar: clean

Closes the cycle named in E-OGAR-AUTH-MIRROR-DRIFT (lance-graph #596 /
sibling-merged as #595/81d08c42): mirror updates must land in the SAME
commit as any OGAR-side ALL-list extension. This PR demonstrates the
discipline working — OGAR #111 merged this morning, the mirror catches
up this afternoon (instead of three days later when q2's lock bumps).

Source-of-finding:
  - AdaWorldAPI/OGAR#111 (introduced PRODUCT + ACCOUNTING_ACCOUNT)
  - AdaWorldAPI/odoo-rs#14 (the upstream finding: 11 missing OdooPort aliases)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@AdaWorldAPI, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 43 minutes and 52 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cc00c209-7097-4e9d-8bc7-6fe6fed6ccba

📥 Commits

Reviewing files that changed from the base of the PR and between 36059ce and 6d7bc28.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • crates/lance-graph-contract/src/ogar_codebook.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI AdaWorldAPI merged commit 1b2c450 into main Jun 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants